Skip to content

[swift5]Add validation rule and validator#14218

Merged
4brunu merged 15 commits intoOpenAPITools:masterfrom
maoyama:add-validation-rule-and-validator
Dec 23, 2022
Merged

[swift5]Add validation rule and validator#14218
4brunu merged 15 commits intoOpenAPITools:masterfrom
maoyama:add-validation-rule-and-validator

Conversation

@maoyama
Copy link
Contributor

@maoyama maoyama commented Dec 8, 2022

#8024 is same in Swift, so I implemented.
First of all, Strings and Numbers are supported. Others will be added in due course.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@maoyama maoyama changed the title Add validation rule and validator [swift5]Add validation rule and validator Dec 10, 2022
@maoyama
Copy link
Contributor Author

maoyama commented Dec 12, 2022

@4brunu May I please get a review, thank you 🙏

@4brunu
Copy link
Contributor

4brunu commented Dec 22, 2022

Hi @maoyama, CI is failing, could you please check what's wrong? Thanks

Copy link
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@4brunu 4brunu merged commit 031f0dc into OpenAPITools:master Dec 23, 2022
@wing328 wing328 added this to the 6.3.0 milestone Jan 20, 2023
@honkmaster
Copy link
Contributor

@4brunu @maoyama Our API returns DTOs named ValidationError. Thus, we get invalid redeclaration errors. Is it possible to make the name of structs introduced with this PR changeable?

@4brunu
Copy link
Contributor

4brunu commented Feb 13, 2023

I think we can rename ValidationError, because it's a common error, to something like OpenAPIValidationError.
@honkmaster can you open a PR with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants