Skip to content

[swift5] Add access control to the properties of validation rules#20380

Merged
4brunu merged 4 commits intoOpenAPITools:masterfrom
maoyama:add-access-control-for-validation-rule-property
Dec 27, 2024
Merged

[swift5] Add access control to the properties of validation rules#20380
4brunu merged 4 commits intoOpenAPITools:masterfrom
maoyama:add-access-control-for-validation-rule-property

Conversation

@maoyama
Copy link
Contributor

@maoyama maoyama commented Dec 27, 2024

Related #14218
I added access control to make the validation rules of the generated model accessible from external modules.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11) @dydus0x14 (2023/06)

@4brunu
Copy link
Contributor

4brunu commented Dec 27, 2024

Looks good to me 👍

@4brunu 4brunu merged commit bf9c9a5 into OpenAPITools:master Dec 27, 2024
24 checks passed
@wing328 wing328 added this to the 7.11.0 milestone Jan 20, 2025
@wing328 wing328 changed the title Add access control to the properties of validation rules [swift5] Add access control to the properties of validation rules Jan 20, 2025
timon-sbr pushed a commit to timon-sbr/openapi-generator that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants