[kotlin-server][jaxrs-spec] default value examples#16456
Closed
stephan-strate wants to merge 1 commit intoOpenAPITools:masterfrom
Closed
[kotlin-server][jaxrs-spec] default value examples#16456stephan-strate wants to merge 1 commit intoOpenAPITools:masterfrom
stephan-strate wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
6 tasks
Contributor
Author
|
@wing328 any idea how to fix that? |
Member
|
@stephan-strate if we put double quote on integer/numeric values, that should fix the problem right?
|
Contributor
Author
Yes, as far as I understand all values need to be strings |
Member
|
I've filed #16563 to fix the issue. Please take a look when you've time. |
Contributor
Author
|
Fixed by #16563 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provided some examples for #16455.
Its kinda weird, that the names of
@PathParam("")disappear. Can't really tell why. But what you can see is, that for the enum and integer default values not""is added. For the enum it is not compilable, the integer compiles, but fails at runtime.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(7.0.1 - patch release),7.1.x(minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)