Skip to content

Fix integer default value with double quote (kotlin jaxrs server generator)#16563

Merged
wing328 merged 4 commits intomasterfrom
kotlin-jaxrs-spec-server-parameter-default-value
Sep 12, 2023
Merged

Fix integer default value with double quote (kotlin jaxrs server generator)#16563
wing328 merged 4 commits intomasterfrom
kotlin-jaxrs-spec-server-parameter-default-value

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Sep 12, 2023

  • Fix integer default value with double quote (kotlin jaxrs server generator)
  • add tests

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (7.0.1 - patch release), 7.1.x (minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06)

@wing328 wing328 changed the title ix integer default value with double qutoe (kotlin jaxrs) Fix integer default value with double quote (kotlin jaxrs server generator) Sep 12, 2023
@wing328 wing328 added this to the 7.0.1 milestone Sep 12, 2023
@wing328 wing328 marked this pull request as ready for review September 12, 2023 06:21
@stephan-strate
Copy link
Contributor

Looks good to me, the DoubleQuoteLambda was the missing piece for me.

@wing328 wing328 merged commit 9c4f6c4 into master Sep 12, 2023
@wing328 wing328 deleted the kotlin-jaxrs-spec-server-parameter-default-value branch September 12, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants