[JavaSpring] Call parent fluent setters from child#16497
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Sep 6, 2023
Merged
[JavaSpring] Call parent fluent setters from child#16497wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
Contributor
Author
|
Couldn't find the correct branch to target this PR towards, please advise :) |
Member
|
@robinjhector is this a breaking change? I'll create 7.1.x and 8.0.x tomorrow. |
Member
|
Looks to me the change is transparent to users consuming the auto-generated code. Please correct me if I'm wrong. |
Contributor
Author
It should be transparent, that is my view as well 👍 |
Member
|
👌 let's target current master. |
Member
|
LGTM. Thanks for the PR. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #16496
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(7.0.1 - patch release),7.1.x(minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)Ping JavaSpring committee: @javisst @borsch @banlevente @Zomzog @martin-mfg