Skip to content

Add test case for nullable parent property#16552

Merged
wing328 merged 9 commits intoOpenAPITools:masterfrom
martin-mfg:nullable-parent
Sep 12, 2023
Merged

Add test case for nullable parent property#16552
wing328 merged 9 commits intoOpenAPITools:masterfrom
martin-mfg:nullable-parent

Conversation

@martin-mfg
Copy link
Contributor

This is a follow-up for #16497

I added a testcase for the problem fixed in above PR to .../resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml and .../resources/3_0/spring/petstore-with-fake-endpoints-models-for-testing.yaml.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (7.0.1 - patch release), 7.1.x (minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)

@martin-mfg
Copy link
Contributor Author

The failing JAX-RS test seems to be unrelated, because my PR doesn't change anything in /samples/server/petstore/jaxrs-cxf.

@wing328 wing328 added this to the 7.0.1 milestone Sep 12, 2023
@wing328
Copy link
Member

wing328 commented Sep 12, 2023

agreed. I could reproduce the issue in the master. will try to fix it in another PR.

@wing328 wing328 merged commit d669505 into OpenAPITools:master Sep 12, 2023
@wing328 wing328 mentioned this pull request Sep 12, 2023
6 tasks
@wing328 wing328 changed the title add test case for nullable parent property Add test case for nullable parent property Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants