Skip to content

[python] add inheritance discriminators test#17883

Closed
fa0311 wants to merge 1 commit intoOpenAPITools:masterfrom
fa0311:add-inheritance-discriminators-test
Closed

[python] add inheritance discriminators test#17883
fa0311 wants to merge 1 commit intoOpenAPITools:masterfrom
fa0311:add-inheritance-discriminators-test

Conversation

@fa0311
Copy link
Contributor

@fa0311 fa0311 commented Feb 17, 2024

Added test to #17882

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@fa0311 fa0311 marked this pull request as draft February 17, 2024 19:21
@fa0311 fa0311 force-pushed the add-inheritance-discriminators-test branch from f1365ec to f525954 Compare February 17, 2024 23:14
@fa0311
Copy link
Contributor Author

fa0311 commented Feb 18, 2024

Continue to #17886

@fa0311 fa0311 closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments