[python] Fix Circular imports on inherited discriminators.#17886
Merged
wing328 merged 12 commits intoOpenAPITools:masterfrom Feb 20, 2024
Merged
[python] Fix Circular imports on inherited discriminators.#17886wing328 merged 12 commits intoOpenAPITools:masterfrom
wing328 merged 12 commits intoOpenAPITools:masterfrom
Conversation
5 tasks
wing328
reviewed
Feb 19, 2024
Member
There was a problem hiding this comment.
thanks for the PR.
minor suggestions:
- use the following to avoid the empty line break
{{#hasChildren}}
{{#discriminator}}
...
{{/discriminator}}
{{/hasChildren}}
- for line 22 (empty line), move it between line 20 and 21 so that it will only be included when both hasChilden and discriminator are non-emtpy (or true)
Contributor
Author
There was a problem hiding this comment.
This issue has been fixed.
5 tasks
Member
|
lgtm. thanks for the fix 👍 |
kota65535
pushed a commit
to kota65535/openapi-generator
that referenced
this pull request
Feb 23, 2024
…ols#17886) * [python] add inheritance discriminators test OpenAPITools#16808 * [python] update samples * [python] fix assert in test * [python] fix inheritance discriminators circular import * [python] update samples * [python] undo type changes related to discriminator * [python] remove extraneous processing * [python-pydantic-v1] fix inheritance discriminators circular import * [python] remove type ignore comment * [python] update samples * [python] fix avoid the empty line break * [python] update samples
5 tasks
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #17882, but passed type analysis and added a test
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)