Include common lambdas in generators#3368
Merged
jmini merged 4 commits intoOpenAPITools:masterfrom Jul 18, 2019
MichalFoksa:feature/include-common-lambdas-in-generators
Merged
Include common lambdas in generators#3368jmini merged 4 commits intoOpenAPITools:masterfrom MichalFoksa:feature/include-common-lambdas-in-generators
jmini merged 4 commits intoOpenAPITools:masterfrom
MichalFoksa:feature/include-common-lambdas-in-generators
Conversation
4 tasks
This was referenced Jul 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Various generator used same Mustache lambdas over and over. In this PR,
DefaultCodegenregisters set of following Mustache lambdas:Extension is done in such a way that each generator can:
NOTE: @jmini : I was not sure where to put new methods in
DefaultCodegen. PLS give me an advised or feel free to update it directly.Reviewers