Skip to content

Feature/mustache lambda documentation#3476

Merged
macjohnny merged 3 commits intoOpenAPITools:masterfrom
MichalFoksa:feature/mustache-lambda-documentation
Jul 29, 2019
Merged

Feature/mustache lambda documentation#3476
macjohnny merged 3 commits intoOpenAPITools:masterfrom
MichalFoksa:feature/mustache-lambda-documentation

Conversation

@MichalFoksa
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Follow up PR to #3368.

PR documents common lambdas in templating.

Please have a look into Mustache Lambdas section. Rest of changes are removed trailing spaces by my editor.

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny
Copy link
Member

can you please merge the current master?

@MichalFoksa
Copy link
Contributor Author

Here you are, PR rebased to current master.

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny merged commit 37cdc8e into OpenAPITools:master Jul 29, 2019
@MichalFoksa MichalFoksa deleted the feature/mustache-lambda-documentation branch July 29, 2019 16:24
@wing328 wing328 added this to the 4.1.0 milestone Aug 9, 2019
@wing328
Copy link
Member

wing328 commented Aug 10, 2019

@MichalFoksa thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553

@MichalFoksa
Copy link
Contributor Author

@wing328 You are absolutely welcome! Cogratulation to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments