[Golang] Allow retrieving the underlying configuration for APIClient#3976
[Golang] Allow retrieving the underlying configuration for APIClient#3976wing328 merged 3 commits intoOpenAPITools:masterfrom arvindth:ath-expose-config
Conversation
bkabrda
left a comment
There was a problem hiding this comment.
LGTM 👍 could come handy in some situations.
|
Oh BTW could you do a similar change to the |
|
We should add a warning that modifying the configuration while live can cause data races and potentially unwanted behavior. It was intentionally protected. |
|
@bkabrda I tried to run |
|
@arvindth please commit those and we'll review. |
|
@wing328 could you reopen this PR? I don't think the new commits on the branch will show up otherwise. |
|
After the rebase forward, |
|
Tests passed via https://circleci.com/gh/OpenAPITools/openapi-generator/9674 |
|
I'll file another PR for go-experimental generator |
|
@arvindth thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569 |
1 similar comment
|
@arvindth thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569 |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
*http.ClientAccessor #3412cc @antihax @bvwells @grokify @kemokemo @bkabrda since this is a Go related change.