Skip to content

go: add os import in case of File return type#3996

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
banzaicloud:go-file-return
Oct 1, 2019
Merged

go: add os import in case of File return type#3996
wing328 merged 1 commit intoOpenAPITools:masterfrom
banzaicloud:go-file-return

Conversation

@bonifaido
Copy link
Contributor

@bonifaido bonifaido commented Sep 30, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixes: #3976

cc @antihax @bvwells @grokify @kemokemo @bkabrda since this is a Go related change.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit c8ac41c into OpenAPITools:master Oct 1, 2019
@bonifaido bonifaido deleted the go-file-return branch October 1, 2019 06:40
Jesse0Michael pushed a commit to Jesse0Michael/openapi-generator that referenced this pull request Oct 3, 2019
@wing328
Copy link
Member

wing328 commented Oct 4, 2019

@bonifaido thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456

@bonifaido
Copy link
Contributor Author

Thank you for the heads up @wing328 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments