Update maven-javadoc-plugin for Java 11 support#5361
Update maven-javadoc-plugin for Java 11 support#5361wing328 merged 6 commits intoOpenAPITools:masterfrom
Conversation
… Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module` error that happens when using Java 11
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
|
Please have a look at the CircleCI errors when you've time: https://circleci.com/gh/OpenAPITools/openapi-generator/12780 |
… Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module` error that happens when using Java 11
|
@wing328 Thank you so much! Fixed both. |
# Conflicts: # modules/openapi-generator/src/main/resources/Java/libraries/jersey2/pom.mustache # modules/openapi-generator/src/main/resources/Java/libraries/rest-assured/pom.mustache # samples/client/petstore/java/jersey2-java6/pom.xml # samples/client/petstore/java/jersey2-java8/pom.xml # samples/client/petstore/java/jersey2/pom.xml
Please update the Java rest-assured pom.xml when you've time. |
|
My apologies; there was an unnecessary letter committed by accident; removed now. |
|
I tested with different JDKs via https://travis-ci.org/OpenAPITools/openapi-generator/builds/652541701 JDK10 failed as expected without the workaround. JDK13 is not yet supported. Overall the result is good. |
|
Much appreciated! |
* Resolves `An error has occurred in Javadoc report generation: [ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module` error that happens when using Java 11 * Resolves `An error has occurred in Javadoc report generation: [ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module` error that happens when using Java 11 * Fix duplicate configuration entries * Fix okhttp poms * Remove letter that shouldn't be there
|
@kibertoad thanks for the PR, which has been included in the 4.3.0 release: https://twitter.com/oas_generator/status/1243455743937789952 |
Resolves
An error has occurred in Javadoc report generation: [ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed moduleerror that happens when using Java 11./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.