[java] Specify Java version for maven-javadoc-plugin (fixes Java 11 error)#6260
Closed
aloisklink wants to merge 5 commits intoOpenAPITools:masterfrom
Closed
[java] Specify Java version for maven-javadoc-plugin (fixes Java 11 error)#6260aloisklink wants to merge 5 commits intoOpenAPITools:masterfrom
aloisklink wants to merge 5 commits intoOpenAPITools:masterfrom
Conversation
on-behalf-of: @nqminds <info@nquiringminds.com>
We add the following <source> tag to the <configuration> of maven-javadoc-plugin for most pom.mustache files that use it. This tells javadoc which version of java the compiler used. This fixes the following error when running Java 11: [ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module Additionally, we also add maven-compiler-plugin to jersey2/pom.mustache to specify that the source code is Java 6/7/8. on-behalf-of: @nqminds <info@nquiringminds.com>
Pull-request OpenAPITools#4666 changed jersey generation, but didn't update the test samples Tests now succeed. on-behalf-of: @nqminds <info@nquiringminds.com>
Running mvn integration-test failed in samples/client/petstore/java/retrofit2-play24 This merges pull requests OpenAPITools#1735 and OpenAPITools#5527 into retrofit2-play24. Also removes the jackson-databind-version field, since it should always be the same as jackson-version, and updates build.gradle/build.sbt on-behalf-of: @nqminds <info@nquiringminds.com>
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Member
|
@aloisklink thanks for the PR. Can you please resolve the merge conflicts when you've time? |
Fixes merge conflicts due to Jackson Databind version increase OpenAPITools#6328
Contributor
Author
|
Hi @wing328, cheers letting me know about the merge conflicts! I swear Github used to send out alerts if there was a merge conflict, but maybe I was imagining it. |
5 tasks
Member
|
@aloisklink thanks for the PR. Merged via #6679 (with merge conflicts resolved) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify the Java version to
maven-javadoc-plugin. This is essentially just adding the<source>java.version</source>tag topom.mustachefiles, e.g.:for almost all clients, except java/rest-assured, which I hard-coded to
<source>1.8</source>, since it only supports Java 8.This fixes the same issue as #5361 when trying to use generated clients in Java 11:
An error has occurred in Javadoc report generation: [ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module error that happens when using Java 11Additionally, I've fixed the broken integration tests in
java/retrofit2-play24andjava/jersey2-java6.java/feigntests are also failing, but that should be fixed by the already pending pull request #5786.PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.