[Java] remove deprecated jackson classes#5786
Closed
jonfreedman wants to merge 10 commits intoOpenAPITools:masterfrom
Closed
[Java] remove deprecated jackson classes#5786jonfreedman wants to merge 10 commits intoOpenAPITools:masterfrom
jonfreedman wants to merge 10 commits intoOpenAPITools:masterfrom
Conversation
Contributor
Author
|
This should now be at the point where we just have some test failures due to a change in behaviour, is there any reason why Jackson classes are being used to do this date parsing rather than just SimpleDateFormat and java.util.time classes? |
5 tasks
…cated-jackson-classes # Conflicts: # samples/client/petstore/java/jersey2/src/main/java/org/openapitools/client/RFC3339DateFormat.java
Member
@jonfreedman Don't recall the reason. Can you please resolve the merge conflicts when you've time? Thanks again and sorry for the delay in reviewing. |
6 tasks
Member
|
Closed via #7304 |
Contributor
Author
|
Thanks for merging, I was going to take a look at this next week as I'm currently on holiday, I need to check if the webclient generator needs the same fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5779
Removes references to ISO8601DateFormat and ISO8601Utils both of which are deprecated since Jackson 2.9.0 and replace with StdDateFormat
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda