Remove the json dependency#6580
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Jun 10, 2020
jfeltesse-mdsol:ruby/rm_json_dep
Merged
Remove the json dependency#6580wing328 merged 1 commit intoOpenAPITools:masterfrom jfeltesse-mdsol:ruby/rm_json_dep
wing328 merged 1 commit intoOpenAPITools:masterfrom
jfeltesse-mdsol:ruby/rm_json_dep
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON has been included in ruby since 1.9:
Forcing everyone to use a recent version like 2.1+ is a good thing but sometimes it may be detrimental: some older apps may still be stuck on 1.x for some reason and currently they wouldn't be able to use generated clients because of the 2.1+ requirement.
Unless there's a specific reason to use 2.1+ in the clients, listing (or not) json as a dependency should be up to the user of the generated clients.
For example, rails dropped the explicit dependency a long time ago (PR).
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@cliffano @zlx @autopp @wing328