Conversation
| # Save response body into a file in (the defined) temporary folder, using the filename | ||
| # from the "Content-Disposition" header if provided, otherwise a random filename. | ||
| # The response body is written to the file in chunks in order to handle files which | ||
| # size is larger than maximum Ruby String or even larger than the maximum memory a Ruby | ||
| # process can use. | ||
| # | ||
| # @see Configuration#temp_folder_path | ||
| def download_file(request) |
There was a problem hiding this comment.
This seems to have mostly been moved.
Note: I don't know if we should expose as is.
There was a problem hiding this comment.
It's only there to support the if opts[:return_type] == 'File' case. I don't think it's hurting anything and could one day be useful so I'd leave it
| require 'constants' | ||
| require 'factory_bot' | ||
|
|
||
| # Require shared spec examples | ||
| Dir["./spec/support/**/*.rb"].sort.each { |f| require f } |
There was a problem hiding this comment.
@kleinjm switching to 5.0.0 seem to overwrite the changes you made. We would have to move them to the corresponding template.
|
|
||
| # Set with nullable attributes. | ||
| # List of attributes with nullable: true | ||
| def self.openapi_nullable | ||
| nullable_properties = Set.new | ||
|
|
||
| nullable_properties.add("timestamp") | ||
|
|
||
| nullable_properties.add("gas_used") | ||
|
|
||
| nullable_properties.add("transaction_value_eth_gwei") | ||
|
|
||
| nullable_properties.add("project_id") | ||
|
|
||
| nullable_properties.add("create_order") | ||
|
|
||
| nullable_properties | ||
| Set.new([ | ||
| :'timestamp', | ||
| :'gas_used', | ||
| :'transaction_value_eth_gwei', | ||
| :'project_id', | ||
| :'create_order' | ||
| ]) | ||
| end |
There was a problem hiding this comment.
This seems like a legit cleaner way to do this.
| gem 'pry-byebug' | ||
| gem 'rubocop' | ||
| gem 'factory_bot' | ||
| gem 'rubocop', '~> 0.66.0' |
There was a problem hiding this comment.
This is still in the lockfile thanks to the gemspec file.
| s.required_ruby_version = ">= 1.9" | ||
|
|
||
| s.add_runtime_dependency 'typhoeus', '~> 1.0', '>= 1.0.1' | ||
| s.add_runtime_dependency 'json', '~> 2.1', '>= 2.1.0' |
There was a problem hiding this comment.
See OpenAPITools/openapi-generator#6580 for details
kleinjm
left a comment
kleinjm
left a comment
There was a problem hiding this comment.
Not looking super closely at every file but LGTM based on how the generator is now configured. Nice work!
| gem 'rake', '~> 13.0.1' | ||
| gem 'pry-byebug' | ||
| gem 'rubocop' | ||
| gem 'factory_bot' |
There was a problem hiding this comment.
is factorybot a dependency of another gem? I see it's removed here but still in the lock file
There was a problem hiding this comment.
It gets added via the gemspec file (interestingly the template does not manage the Gemfile directly)
| # Save response body into a file in (the defined) temporary folder, using the filename | ||
| # from the "Content-Disposition" header if provided, otherwise a random filename. | ||
| # The response body is written to the file in chunks in order to handle files which | ||
| # size is larger than maximum Ruby String or even larger than the maximum memory a Ruby | ||
| # process can use. | ||
| # | ||
| # @see Configuration#temp_folder_path | ||
| def download_file(request) |
There was a problem hiding this comment.
It's only there to support the if opts[:return_type] == 'File' case. I don't think it's hurting anything and could one day be useful so I'd leave it
Co-authored-by: James Klein <kleinjm007@gmail.com>
2 participants
What
Generated by https://github.com/patch-technology/client-code-generation/pull/30
Why
SDK Release Checklist