Add support of useOneOfInterfaces for Spring and all JaxRS based generators#6589
Open
rfecher wants to merge 1 commit intoOpenAPITools:masterfrom
Open
Add support of useOneOfInterfaces for Spring and all JaxRS based generators#6589rfecher wants to merge 1 commit intoOpenAPITools:masterfrom
rfecher wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
…rators Add support of useOneOfInterfaces for Spring and all JaxRS based generators
Member
|
@rfecher thanks for the PR. Can you please PM me via Slack to discuss this PR? |
|
hey guys, any updates on this PR? |
6 tasks
|
Could we get an update on this PR? Currently, none of the JAX-RS generators handle oneOf correctly. With #8091, the foundational work in the Java base (abstract) code generation classes has already been completed. I did a quick test and it looks like all what needs to be done is to integrate the JAX-RS Mustache templates from this PR to ensure that proper interfaces are created when useOneOfInterfaces is enabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is actually referenced here and it addresses issue #5381 nicely.
I'm willing to do the legwork to get the PR in, however I'm not actually the author, and I'd think to maintain the license agreement we'd need consent from @mmalygin
PR checklist
this step is unclear to me, I run a bunch of the scripts and it seems many seemingly unrelated files changed like all the FakeApi.java files changed
put("http", EncodingUtils.encodeCollection(value, "ssv"));toput("http", EncodingUtils.encodeCollection(value, "space"));which seems completely outside of the scope of this bugfix./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.further guidance would be appreciated here