[Spring][server] oneOf Interface for Spring Boot#8091
Closed
jburgess wants to merge 27 commits intoOpenAPITools:masterfrom
Closed
[Spring][server] oneOf Interface for Spring Boot#8091jburgess wants to merge 27 commits intoOpenAPITools:masterfrom
jburgess wants to merge 27 commits intoOpenAPITools:masterfrom
Conversation
added x-is-one-of-interface extension for oneOf interface in mustache template
fixed name of model from UNKNOWN_BASE_TYPE to right one in api: operationId + OneOf Fix OpenAPITools#5381 parcelableModel is not required
removed not needed methods
catch NPE cases in preprocessOpenAPI updated samples
…rator into spring_fix_5381
fixed generation of oneOf Models
addOneOfInterfaceModel only for cases when useOneOfInterfaces is true and for spring
NPE fix
…rator into spring_fix_5381
…rator into spring_fix_5381 � Conflicts: � modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java
spring: fixed use of oneOf Models in API
implementing oneOf for spring lib overriding methods with different behavior from default
added x-is-one-of-interface extension for oneOf interface in mustache template
fixed name of model from UNKNOWN_BASE_TYPE to right one in api: operationId + OneOf Fix OpenAPITools#5381 removed not needed methods Fix OpenAPITools#5381 fixed generation of oneOf Models Fix OpenAPITools#5381 addOneOfInterfaceModel only for cases when useOneOfInterfaces is true and for spring Fix OpenAPITools#5381 NPE fix for tests
fixed handing of composed schema with array
fixed NPE in addOneOfInterfaceModel
fixed generation of oneOf models with descriminator
# Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java
Member
|
cc @OpenAPITools/generator-core-team as the change impacts default codegen. |
Contributor
Author
|
@wing328 can I get you to re-run the CI? Looks like a transient dependency download error. |
# Conflicts: # modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java
|
@wing328, hi. |
5 tasks
|
any news on this? |
|
Also would love to have this functionality! |
# Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java # modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java
Contributor
Author
|
I have resolved the merge conflicts. @wing328 can we get this scheduled for a release? |
|
@jburgess thanks for your work so far! Really excited for what happens next! |
5 tasks
Member
|
@jburgess thanks again for the PR and sorry for the delay in reviewing as there're too many PRs. Please resolve the merge conflicts and I'll review later this week. |
5 tasks
Member
|
FYI. I've resolved the merge conflicts and filed #10392 instead. |
Member
|
Closed via #11650 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
OneOfinterfaces for the Java Spring library. Merges #5661 (@alexsuperdev) and #6589 (@rfecher) and refreshes against the main branch.Fixes #5381 and #15 (for Spring)
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda