Skip to content

[SWIFT5] Add the ability to turn uniqueItems array into Set in swift.#6773

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
cerupcat:master
Jun 26, 2020
Merged

[SWIFT5] Add the ability to turn uniqueItems array into Set in swift.#6773
wing328 merged 2 commits intoOpenAPITools:masterfrom
cerupcat:master

Conversation

@cerupcat
Copy link
Contributor

Add the ability to turn uniqueItems array into Set in swift.

CC Swift5 technical committee @jgavris (@ehyche @Edubits @jaz-ah @4brunu

@4brunu
Copy link
Contributor

4brunu commented Jun 25, 2020

Looks good to me.
Could you please update the pet projects ./mvnw package && sh bin/swift5-all.sh and commit the changes?
Thanks

@cerupcat
Copy link
Contributor Author

Thanks @4brunu.

I'm not seeing a swift5-all.sh file though. If I run generate-samples.sh /bin/configs/other/swift5-default.yaml there's no diff.

@4brunu
Copy link
Contributor

4brunu commented Jun 26, 2020

You are right, with version 5.0.0 a lot of things have changed.
Looks like Travis CI is not related to the changes in this PR.
Looks good this change to me 👍

@Override
public String toInstantiationType(Schema p) {
if (ModelUtils.isMapSchema(p)) {
if (ModelUtils.isMapSchema(p)) {
Copy link
Member

@wing328 wing328 Jun 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix the code indentation with 4-space instead of tabs in a separate commit:

update: 5cce9dc

@wing328
Copy link
Member

wing328 commented Jun 26, 2020

Travis CI failure already fixed in the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants