Add support for generating a Set for a list with uniqueItems set to true#9849
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Jul 1, 2021
marcdejonge:9848-kotlin-use-set-for-uniqueItems-array
Merged
Add support for generating a Set for a list with uniqueItems set to true#9849wing328 merged 1 commit intoOpenAPITools:masterfrom marcdejonge:9848-kotlin-use-set-for-uniqueItems-array
wing328 merged 1 commit intoOpenAPITools:masterfrom
marcdejonge:9848-kotlin-use-set-for-uniqueItems-array
Conversation
Contributor
Author
|
@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m Is this the correct solution? I'd much rather go back to the |
Contributor
|
Instead of changing the template, what about changing the java file? |
Contributor
Author
I agree, but the template already doesn't use the dataType at all. The code already contains the logic for using a Set instead of a List (for the kotlin server templates it works fine). I don't know how else to solve this. |
Contributor
|
Thanks, let's go with this solution 👍 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #9848
This specifically adds support for a Set type when a model with an array has
uniqueItemsset to true. This only changes the KotlinClientGenerator template, since that one was missing specific support for it. The tests run agains all 5 generators, but the rest seem to work fine.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x