Fix - Provides a default value for optional init parameters#6827
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Jul 1, 2020
Merged
Conversation
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
The following change can be helpful to create Swift model objects more simply, in particular when they have many parameters. In addition, projects switching from swagger-codegen to OpenAPI will not encounter compilation errors and will not need to refactor old code
alessiozurru
force-pushed
the
fix_swift5_public_init_modelObject_defaultValue
branch
from
8cff0f2 to
3b1402b
Compare
Contributor
|
@alessiozurru Thanks for this PR. |
Contributor
Author
|
@4brunu I already done it but there are not changes to commit. |
Contributor
|
@alessiozurru Thanks, it was just to make sure 👍 |
jimschubert
added a commit
that referenced
this pull request
Jul 3, 2020
* master: (142 commits) update python samples clarify direction of py client side validation flag (#6850) fix erronous cmd arg example for docker in readme (#6846) [BUG] [JAVA] Fix multiple files upload (#4803) (#6808) [kotlin][client] fix retrofit dependencies (#6836) [PowerShell] add more fields to be customized (#6835) [Java][WebClient]remove the dead code from java ApiClient.mustache (#6556) [PHP] Better handling of invalid data (array) (#6760) Make ApiClient in retrofit2 be able to use own OkHttpClient (#6699) mark python2 support in flask as deprecated (#6653) update samples [Java][jersey2] Add a getter for the User-Agent header value (#6831) Provides a default nil value for optional init parameters (#6827) [Java] Deprecate feignVersion option (#6824) [R] Enum R6Class Support, closes #3367 (#5728) [Rust][Client] Unify sync/async client structure (#6753) [php-ze-ph] Set required PHP version to ^7.2 (#6763) [Java][client][native][Gradle] Add missing jackson-databind-nullable (#6802) Improve sttpOpenApiClient generator (#6684) Update docker-tag-latest-release.yml ...
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SWIFT] - The idea is to manage In a more efficiently way the creation of init methods of model objects providing a default nil value for optional parameters.
This is a trivial change to modelObject.mustache template and could be helpful to create Model objects more simply, in particular when they have many parameters.
In addition we could avoid possible compilation error for projects that are switching from swagger-codegen tool which provided an init with empty parameters.
With this change we simply provide the '= nil' default value for all params that are optionals
@jgavris @ehyche @Edubits @jaz-ah @4brunu
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.master