Skip to content

[Swift] Use default values in modelObject initializers#8118

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
allezxandre:master
Dec 9, 2020
Merged

[Swift] Use default values in modelObject initializers#8118
wing328 merged 1 commit intoOpenAPITools:masterfrom
allezxandre:master

Conversation

@allezxandre
Copy link
Contributor

@allezxandre allezxandre commented Dec 8, 2020

PR #6827 introduced nil values in initialisers for non-required parameters, however this behaviour overrides the default values provided to the struct. For instance, this kind of struct would be generated:

public struct ModelObject: Codable {
    public var nonRequiredAttribute: String? = "defaultValue"

    public init(nonRequiredAttribute: String? = nil) {
        self.nonRequiredAttribute = nonRequiredAttribute
    }
}

which would yield:

let model = ModelObject()
print(model.nonRequiredAttribute) // prints "nil" when "defaultValue" is expected

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
    • Returned: [SUCCESS] Batch generation finished 217 generators successfully.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@allezxandre allezxandre changed the title [Swift] Add default values to model initializers [Swift] Use default values in modelObject initializers Dec 8, 2020
@allezxandre allezxandre marked this pull request as ready for review December 8, 2020 01:58
@wing328 wing328 added this to the 5.0.0 milestone Dec 8, 2020
@allezxandre
Copy link
Contributor Author

Tagging the technical committee again as I suspect it didn't work the first time when I submitted as draft:
@jgavris @ehyche @Edubits @jaz-ah @4brunu

(apologies if this is redundant and it actually worked the first time)

@4brunu
Copy link
Contributor

4brunu commented Dec 8, 2020

Looks good to me 👍

@wing328 wing328 merged commit 933a5dc into OpenAPITools:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants