Subclass Python exceptions#7321
Merged
spacether merged 4 commits intoOpenAPITools:masterfrom Sep 5, 2020
ryanrishi:rr/python-exception-subclasses
Merged
Subclass Python exceptions#7321spacether merged 4 commits intoOpenAPITools:masterfrom ryanrishi:rr/python-exception-subclasses
spacether merged 4 commits intoOpenAPITools:masterfrom
ryanrishi:rr/python-exception-subclasses
Conversation
- UnauthorizedException (401) - ForbiddenException (403) - NotFoundException (404) - ServiceException [500 - 599] Fixes #2151
spacether
approved these changes
Sep 5, 2020
Contributor
spacether
left a comment
spacether
left a comment
There was a problem hiding this comment.
These look great, thank you for the PR!
jimschubert
added a commit
to lwlee2608/openapi-generator
that referenced
this pull request
Sep 12, 2020
* master: (1557 commits) [docs] Add notes on Windows classpath modification (OpenAPITools#7404) [C#][netcore] better support for additional properties in the payload (OpenAPITools#7396) Fix the ECDSA signature issue for PowerShellSDK (OpenAPITools#7386) Fix the new package that deal with Configuration (the old one is depecrated) (OpenAPITools#7391) update vonage logo (OpenAPITools#7387) [gradle][plugin] Fix tests (OpenAPITools#7384) [typescript] Fix incorrect enum literal case (OpenAPITools#7378) Rust reqwest/api_mustache Missing api Vec in parameter (OpenAPITools#7049) [kotlin] Fix imports of generated class (OpenAPITools#7314) Properly decode $ref (OpenAPITools#7191) fix typo, update caption feat(r): retry configuration for status codes (OpenAPITools#5925) [json][codegen] Add option: outputFileName (OpenAPITools#7348) RSACng class is not supported on linux replacing it by RSA (OpenAPITools#7349) Adds cookie auth support to ApiKeyAuth in dart2 templates (OpenAPITools#7346) [js][flowtype] Bump lodash from 4.17.15 to 4.17.19 (OpenAPITools#7359) Bugfix swift5 code generation 2966 (OpenAPITools#7301) Syncs validation properties for arraymodels (OpenAPITools#7357) Subclass Python exceptions (OpenAPITools#7321) Adds fix for issue7262 and a test of it (OpenAPITools#7328) ...
Kylmakalle
pushed a commit
to Kylmakalle/openapi-generator
that referenced
this pull request
Dec 4, 2020
* Subclass Python exceptions: - UnauthorizedException (401) - ForbiddenException (403) - NotFoundException (404) - ServiceException [500 - 599] Fixes OpenAPITools#2151 * add generated sample code * use Python 2 flavor inheritance * regenerate samples
spacether
pushed a commit
that referenced
this pull request
Dec 5, 2020
* Subclass Python exceptions (#7321) * Subclass Python exceptions: - UnauthorizedException (401) - ForbiddenException (403) - NotFoundException (404) - ServiceException [500 - 599] Fixes #2151 * add generated sample code * use Python 2 flavor inheritance * regenerate samples * update samples Co-authored-by: Ryan Rishi <ryan@ryanrishi.com> Co-authored-by: William Cheng <wing328hk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subclasses Python exceptions as outlined in #2151:
UnauthorizedException(401)ForbiddenException(403)NotFoundException(404)ServiceException[500 - 599]@taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)