[typescript] Fix incorrect enum literal case

[epidemia]

fixes #7369
Enum values are generated incorrectly for PascalCase enum property naming type when the source enum values are in uppercase with underscores.

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
• Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

[macjohnny]

please add some docs to explain what this function does, and include an example

I am just asking myself: why can't we use the underscore method?

openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/utils/StringUtils.java

Line 59 in eb62e21

public static String underscore(final String word) {

[epidemia]

Yes, I can use the underscore method. I deleted prepareEnumString method. Thanks.

[macjohnny]

this is a breaking change, but the fallback is to use enumPropertyNaming=original

[epidemia]

this is a breaking change, but the fallback is to use enumPropertyNaming=original

@macjohnny Can you give an example of broken backward compatibility?

[macjohnny]

this is a breaking change, but the fallback is to use enumPropertyNaming=original

@macjohnny Can you give an example of broken backward compatibility?

Since the default value of enumPropertyNaming is PascalCase (see https://openapi-generator.tech/docs/generators/typescript-axios), for a user that does not explicitly specify enumPropertyNaming, your example

         "type": {
            "type": "string",
            "description": "Book type",
            "enum": [
              "SCIENCE",
              "SCIENCE_FICTION"
            ]
          }

currently results in

export enum BookType {
  SCIENCE = 'SCIENCE',
  SCIENCEFICTION = 'SCIENCE_FICTION'
}

With your change it results in

export enum BookType {
  Science = 'SCIENCE',
  ScienceFiction = 'SCIENCE_FICTION'
}

thus breaking his code using that enum. But he can easily use the enumPropertyNaming=original to fall back to the original behavior

[epidemia]

this is a breaking change, but the fallback is to use enumPropertyNaming=original

@macjohnny Can you give an example of broken backward compatibility?

Since the default value of enumPropertyNaming is PascalCase (see https://openapi-generator.tech/docs/generators/typescript-axios), for a user that does not explicitly specify enumPropertyNaming, your example

         "type": {
            "type": "string",
            "description": "Book type",
            "enum": [
              "SCIENCE",
              "SCIENCE_FICTION"
            ]
          }

currently results in

export enum BookType {
  SCIENCE = 'SCIENCE',
  SCIENCEFICTION = 'SCIENCE_FICTION'
}

With your change it results in

export enum BookType {
  Science = 'SCIENCE',
  ScienceFiction = 'SCIENCE_FICTION'
}

thus breaking his code using that enum. But he can easily use the enumPropertyNaming=original to fall back to the original behavior

All right. Thank you.