fix(codex): wrap token-store JSON parse errors and use atomic write (#128)

[hqhq1025]

Summary

Win11 用户偶发 `Error invoking remote method 'codesign:v1:generate': CodesignError: Unexpected end of JSON input`。根因：`codex-auth.json` 被进程被 kill / antivirus 干扰 truncate 后，`token-store.read()` 抛裸 `Error`，IPC 透传时只剩 `SyntaxError.message`，用户完全不知所措。

What changed

• `packages/providers/src/codex/token-store.ts`：
  • `read()` 的 `JSON.parse` 失败 → `CodesignError(CODEX_TOKEN_PARSE_FAILED)` with `SyntaxError` as cause
  • schema invalid → 同样归到 `CODEX_TOKEN_PARSE_FAILED`
  • "未登录"路径 → `CodesignError(CODEX_TOKEN_NOT_LOGGED_IN)`
  • `write()` 改原子写：写到 `${path}.tmp.${pid}` 再 `rename`，失败时清理 tmp（参考 `reported-fingerprints.ts:75` 的模式）
• `packages/shared/src/error-codes.ts` + i18n (en/zh-CN)：新增 `CODEX_TOKEN_PARSE_FAILED` + `CODEX_TOKEN_NOT_LOGGED_IN` 两个 code，文案分别提示"重新登录"

Test plan

• 5 new tests in `token-store.test.ts`：truncated JSON / invalid schema / not-logged-in / atomic write failure / tmp cleanup
• `pnpm test` providers (136) all green
• `pnpm typecheck` + `pnpm lint` clean

Closes #128

[github-actions]

Findings

• [Major] PID-only tmp path can break atomic writes under concurrent calls — write() now always targets ${filePath}.tmp.${pid}. Two concurrent writes in the same process can race on the same tmp file (overwrite/unlink each other), causing failed or lost credential persistence, evidence packages/providers/src/codex/token-store.ts:98.
  Suggested fix:

  import { randomUUID } from 'node:crypto';
  
  const tmpPath = `${this.filePath}.tmp.${process.pid}.${randomUUID()}`;

Summary

• Review mode: initial
• 1 issue found in fresh diff.
• docs/VISION.md / docs/PRINCIPLES.md are Not found in repo/docs in this checkout, so this review used CLAUDE.md + changed source files only.

open-codesign Bot

Testing

• Not run (automation)
• Suggested tests: add a concurrent Promise.all([store.write(a), store.write(b)]) case asserting no .tmp.* leftovers and final file JSON is valid.

[github-actions]

Using only process.pid in tmpPath makes concurrent writes in the same process collide on one temp file. Please make temp names unique per write (for example add randomUUID()), so atomicity still holds when write() is called concurrently.

import { randomUUID } from 'node:crypto';

const tmpPath = `${this.filePath}.tmp.${process.pid}.${randomUUID()}`;

[github-actions]

Findings

• [Major] 原子写临时文件名只使用 process.pid，同一进程内并发调用 write() 会竞争同一个 tmp 文件，可能互相覆盖/删除并导致凭证写入失败或丢失，证据 packages/providers/src/codex/token-store.ts:98。
  Suggested fix:

  import { randomUUID } from 'node:crypto';
  
  const tmpPath = `${this.filePath}.tmp.${process.pid}.${randomUUID()}`;

Summary

• Review mode: follow-up after new commits
• 发现 1 个问题（以上）。
• docs/VISION.md、docs/PRINCIPLES.md：Not found in repo/docs（本次仓库副本中不存在）。

Testing

• Not run (automation)
• 建议补充：Promise.all([store.write(a), store.write(b)]) 并发写测试，断言最终 JSON 合法且无 .tmp.* 残留。

open-codesign Bot

[github-actions]

tmpPath 只包含 process.pid 时，同进程并发写会撞名，导致原子写退化（覆盖/误删同一 tmp）。建议给每次写入增加唯一后缀（例如 randomUUID()）：

import { randomUUID } from 'node:crypto';
const tmpPath = `${this.filePath}.tmp.${process.pid}.${randomUUID()}`;

[github-actions]

Findings

• 未发现达到报告阈值（>=80% 置信度）的新增问题。

Summary
Review mode: follow-up after new commits

• 本次 follow-up 提交已修复上一轮指出的并发 tmpPath 冲突问题：packages/providers/src/codex/token-store.ts:102 使用 randomUUID()，并新增并发写回归测试 packages/providers/src/codex/token-store.test.ts:326。
• 约束检查（本次变更范围内）：未发现直接 provider SDK 引入、未发现 silent fallback、新增错误码已在共享错误码表登记。
• docs/VISION.md、docs/PRINCIPLES.md: Not found in repo/docs（当前仓库副本中不存在）。
• 残余风险：未在本次自动化中复跑全量 CI，仅基于 diff 与测试代码静态审阅。

Testing

• Not run (automation)

open-codesign Bot