-
Notifications
You must be signed in to change notification settings - Fork 146
feat: warn about coding plan app allowlists #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
139601c
fix: enable reasoning for third-party OpenAI-compatible proxies (issu…
Sun-sunshine06 8abe2ae
fix: cover namespaced openai reasoning models on proxies
Sun-sunshine06 c081512
feat: warn about coding plan app allowlists
Sun-sunshine06 5678f5f
fix: address bot review feedback
Sun-sunshine06 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
39 changes: 39 additions & 0 deletions
39
apps/desktop/src/renderer/src/components/AddCustomProviderModal.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import { renderToStaticMarkup } from 'react-dom/server'; | ||
| import { describe, expect, it, vi } from 'vitest'; | ||
| import { AddCustomProviderModal } from './AddCustomProviderModal'; | ||
|
|
||
| vi.mock('@open-codesign/i18n', () => ({ | ||
| useT: () => (key: string) => key, | ||
| })); | ||
|
|
||
| describe('AddCustomProviderModal', () => { | ||
| it('shows the compatibility warning for editable custom endpoints', () => { | ||
| const html = renderToStaticMarkup( | ||
| <AddCustomProviderModal onSave={() => undefined} onClose={() => undefined} />, | ||
| ); | ||
|
|
||
| expect(html).toContain('settings.providers.custom.compatibilityHintTitle'); | ||
| expect(html).toContain('settings.providers.custom.compatibilityHintBody'); | ||
| }); | ||
|
|
||
| it('hides the compatibility warning when editing a locked builtin endpoint', () => { | ||
| const html = renderToStaticMarkup( | ||
| <AddCustomProviderModal | ||
| onSave={() => undefined} | ||
| onClose={() => undefined} | ||
| editTarget={{ | ||
| id: 'anthropic', | ||
| name: 'Anthropic', | ||
| baseUrl: 'https://api.anthropic.com', | ||
| wire: 'anthropic', | ||
| defaultModel: 'claude-sonnet-4-5', | ||
| builtin: true, | ||
| lockEndpoint: true, | ||
| }} | ||
| />, | ||
| ); | ||
|
|
||
| expect(html).not.toContain('settings.providers.custom.compatibilityHintTitle'); | ||
| expect(html).not.toContain('settings.providers.custom.compatibilityHintBody'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently includes broad cloud domains (, ). That suppresses this hint for many third-party relays hosted on AWS/Azure, creating false negatives for the exact allowlist problem this UI is trying to explain. Please narrow this to provider-specific official endpoint patterns instead of whole-cloud suffixes.\n\n