Conversation
… Fonts CDN) Remove the three Google Fonts <link> tags from the renderer entry HTML. The app already loads Geist + Fraunces + JetBrains Mono via @fontsource-variable/* through @open-codesign/ui/fonts, so the CDN links were both redundant (the Plus Jakarta family they pulled isn't referenced by any --font-* token after the warm-aesthetic refresh) and a hard-constraint violation: every cold start pinged fonts.googleapis.com / fonts.gstatic.com, breaking BYOK / no-telemetry defaults and offline launch.
Contributor
There was a problem hiding this comment.
Findings
- No high-confidence issues found in added/modified lines.
Summary
- Review mode: initial
- No issues identified in this diff. Residual risk: visual regression is still possible if local font-face assets are not present at runtime (not verifiable from this diff alone).
- open-codesign Bot
Testing
- Not run (automation)
hqhq1025
added a commit
that referenced
this pull request
Apr 19, 2026
… Fonts CDN) (#53) Remove the three Google Fonts <link> tags from the renderer entry HTML. The app already loads Geist + Fraunces + JetBrains Mono via @fontsource-variable/* through @open-codesign/ui/fonts, so the CDN links were both redundant (the Plus Jakarta family they pulled isn't referenced by any --font-* token after the warm-aesthetic refresh) and a hard-constraint violation: every cold start pinged fonts.googleapis.com / fonts.gstatic.com, breaking BYOK / no-telemetry defaults and offline launch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the three
<link rel="preconnect|stylesheet">tags pointing atfonts.googleapis.com/fonts.gstatic.comfromapps/desktop/src/renderer/index.html. The renderer already loads Geist + Fraunces + JetBrains Mono locally via@fontsource-variable/*through@open-codesign/ui/fonts(wired fromapps/desktop/src/renderer/src/main.tsx:2), so these CDN links were both redundant and a hard-constraint violation.Why this matters
preconnects and a stylesheet GET to Google before the app even rendered — i.e., a third-party network ping by default, no opt-in. CLAUDE.md is explicit: "no telemetry by default."<link rel="stylesheet">until the request timed out, then render with the system fallback.display=swapmeant first paint usedsystem-ui, then re-flowed once the CDN font landed — visible flash on every launch.fonts.googleapis.comis unreachable from many networks; users in those regions were getting permanent fallback rendering with no indication why.What I changed (and didn't change)
apps/desktop/src/renderer/index.html— removed lines 8–13 (the 3 Google Fonts links). One file, six lines deleted.@fontsource-variable/plus-jakarta-sanstopackages/uias the audit suggested. After thefeat(ui): Anthropic-inspired warm aestheticrefresh (commit 269658d),--font-sansresolves to"Geist Variable"and--font-displayto"Fraunces Variable"(seepackages/ui/src/tokens.css:56-58). ThePlus+Jakarta+Sansfamily the CDN was loading is not referenced by any token or component — it was dead weight from a pre-refresh era. Adding the fontsource package would have shipped ~120KB of woff2 nobody renders.@fontsource-variable/jetbrains-monoinpackages/ui/src/fonts.ts:7, so the CDN's mono load was also redundant.Verification
pnpm typecheck— pass (10/10 turbo tasks)pnpm lint— only pre-existing warnings, no new findingspnpm build(electron-builder) — exit 0; ignored hdiutil cleanup quirks are unrelated to this changepnpm test(pre-commit hook) — 138/138 desktop, all packages greenapps/desktop/out/renderer/index.html—grepforfonts.googleapis|fonts.gstaticreturns 0 matchesassets/directory contains all expected woff2 subsets (geist-, fraunces-, jetbrains-mono-*)Test plan
fonts.googleapis.com/fonts.gstatic.comPrinciples checklist