Linear Trim Solution Improvements#1275
Merged
ebranlard merged 1 commit intoOpenFAST:devfrom Oct 7, 2022
Merged
Conversation
- The operating point used for trim solutions cannot use GetSmllRotAngs since we can't assume all angles in the simulation are less than 25 degrees. It reverted back to log maps for this calculation. - I removed the rotational accelerations from the packed arrays for trim solution. These can be noisy outputs, and we are already making sure that the position and velocity values are converging. - I updated the argument names in the `GetOP` routines for the structural codes that output motions. This is a follow-up to OpenFAST#1158.
jjonkman
approved these changes
Oct 7, 2022
Collaborator
jjonkman
left a comment
jjonkman
left a comment
There was a problem hiding this comment.
I have discussed these changes with Bonnie and generally agree with the solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
The packed operating point array that is used to see if the turbine has reached steady-state in a trim solution was modified in #1050 to assume that all orientation angles in the code are small (<25 deg). Since this is not a valid assumption, I have reverted that code to use log maps.
Also, I have removed the rotational accelerations from the packed arrays for the trim solution. These can be noisy outputs that don't want to converge in this algorithm; since we are already making sure that the position and velocity values are converging, these accelerations should not also have to be in the convergence calculation.
For code readability, I changed the names of some arguments in the
GetOPandPackMeshMotionroutines.Also, I fixed an issue where the SD operating point for inputs would not have been displayed correctly in linearization output files.
Related issue, if one exists
This is a follow-up to #1158.
Impacted areas of the software
Linear trim solution (BD, ED, SD structural codes)
Test results, if applicable
This should not change any r-test results.
For other cases that use the trim solution, it is possible that it will now converge sooner than in previous versions of the code, possibly leading to insignificant differences in the steady-state solution.