Reduce memory requirements for regression tests after PR #1008#1598
Merged
andrew-platt merged 3 commits intoOpenFAST:devfrom Jun 1, 2023
Merged
Reduce memory requirements for regression tests after PR #1008#1598andrew-platt merged 3 commits intoOpenFAST:devfrom
andrew-platt merged 3 commits intoOpenFAST:devfrom
Conversation
Tests will need updating.
03d6224 to
0b6ef93
Compare
Collaborator
Author
|
The following cases were modified:
|
6161ff6 to
9f8e3d7
Compare
Collaborator
Author
|
@luwang00, can you review this? |
deslaughter
approved these changes
Jun 1, 2023
Contributor
Hi @andrew-platt, the changes look good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not ready to merge yet.
Feature or improvement description
PR #1008 introduced potentially larger memory requirements for the SeaState than previously required for HydroDyn. This causes GitHub actions to fail when memory is exhausted.
Also minor fix so that the docs will build on readthedocs.org.
Related issue, if one exists
#1008
Impacted areas of the software
No code changes are introduced with this PR.
Additional supporting information
Additional changes may be required after this PR is started.
Test results, if applicable
Many tests involving SeaState have been changed to use a smaller
WaveTMaxso as to reduce memory requirements. This causes the wave elevation data to look significantly different because of the way the random numbers are used during generation of the wave spectrum. As a result, many tests will need updating.RANLUXin all SeaState cases (should have occured with Update HydroDyn driver cases to use RANLUX r-test#96).outfiles in favor of keeping only the.outbfiles. Remove extra stuff (summary etc) from regression tests.