Skip to content

Reduce memory requirements for regression tests after PR #1008#1598

Merged
andrew-platt merged 3 commits intoOpenFAST:devfrom
andrew-platt:b/RegTestMemory
Jun 1, 2023
Merged

Reduce memory requirements for regression tests after PR #1008#1598
andrew-platt merged 3 commits intoOpenFAST:devfrom
andrew-platt:b/RegTestMemory

Conversation

@andrew-platt
Copy link
Collaborator

@andrew-platt andrew-platt commented May 31, 2023

This PR is not ready to merge yet.

Feature or improvement description
PR #1008 introduced potentially larger memory requirements for the SeaState than previously required for HydroDyn. This causes GitHub actions to fail when memory is exhausted.

Also minor fix so that the docs will build on readthedocs.org.

Related issue, if one exists
#1008

Impacted areas of the software
No code changes are introduced with this PR.

Additional supporting information
Additional changes may be required after this PR is started.

Test results, if applicable
Many tests involving SeaState have been changed to use a smaller WaveTMax so as to reduce memory requirements. This causes the wave elevation data to look significantly different because of the way the random numbers are used during generation of the wave spectrum. As a result, many tests will need updating.

  • Verify meet memory requirements. Reduce grid sizes in SeaState further if needed.
  • Verify we are using RANLUX in all SeaState cases (should have occured with Update HydroDyn driver cases to use RANLUX r-test#96)
  • Update regression test results
  • While we are at it, remove the .out files in favor of keeping only the .outb files. Remove extra stuff (summary etc) from regression tests.

@andrew-platt andrew-platt self-assigned this May 31, 2023
@andrew-platt andrew-platt added this to the v4.0.0 milestone May 31, 2023
@andrew-platt andrew-platt added Module: HydroDyn Module: SeaState SeaState module for wave data generation labels May 31, 2023
@andrew-platt
Copy link
Collaborator Author

The following cases were modified:

Name WaveTMax original WaveTMax new
5MW_ITIBarge_DLL_WTurb_WavesIrr 3630 600
5MW_OC3Mnpl_DLL_WTurb_WavesIrr 3630 600
5MW_OC3Spar_DLL_WTurb_WavesIrr 3630 600
5MW_OC3Trpd_DLL_WSt_WavesReg 3630 600
5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth 3630 600
5MW_OC4Semi_Linear 4600 600
5MW_OC4Semi_WSt_WavesWN 4600 600
5MW_TLP_DLL_WTurb_WavesIrr_WavesMulti 3630 600
StC_test_OC4Semi 4600 600
hd_5MW_ITIBarge_DLL_WTurb_WavesIrr 3630 600
hd_5MW_OC3Spar_DLL_WTurb_WavesIrr 3630 600
hd_5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth 3630 600
hd_5MW_OC4Semi_WSt_WavesWN 4600 600
hd_5MW_TLP_DLL_WTurb_WavesIrr_WavesMulti 3630 600
hd_NBodyMod1 4600 600
hd_NBodyMod2 4600 600
hd_NBodyMod3 4600 600
hd_OC3tripod_offshore_fixedbottom_wavesirr 3630 600
py_hd_5MW_OC4Semi_WSt_WavesWN 4600 600
seastate_1 4600 600
seastate_wavemod5 4600 600
seastate_wr_kin1 4600 600

@andrew-platt
Copy link
Collaborator Author

@luwang00, can you review this?

@luwang00
Copy link
Contributor

luwang00 commented Jun 1, 2023

@luwang00, can you review this?

Hi @andrew-platt, the changes look good to me.

@andrew-platt andrew-platt merged commit 7e8be52 into OpenFAST:dev Jun 1, 2023
@andrew-platt andrew-platt deleted the b/RegTestMemory branch June 5, 2023 19:14
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module: HydroDyn Module: SeaState SeaState module for wave data generation Type: Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments