Update HydroDyn driver cases to use RANLUX#96
Merged
andrew-platt merged 2 commits intodevfrom May 31, 2023
Merged
Conversation
Otherwise, the random numbers used to generate wave data are not the same on different systems.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the hydrodyn driver cases were using the intrinsic random number generator to generate wave data, which produced different results on different compilers.
Results updated here were generated with Intel Parallel Studio XE 2019 Update 5 with Visual Studio 2017.
Wave elevations have changed:
