Increase length of error messages#2710
Merged
andrew-platt merged 2 commits intoOpenFAST:rc-4.0.3from Apr 2, 2025
Merged
Conversation
Contributor
|
@andrew-platt , I just pushed some code that I have used to capture some of the excessively long error messages in my own code base. Not sure if you want to use this in addition to or instead of your very long error messages, but it's here: d73d812 |
deslaughter
approved these changes
Mar 31, 2025
Collaborator
|
I think we should go with |
Collaborator
Author
|
I agree with @deslaughter. Let's put @bjonkman's solution into v5.0 or 4.1 (see issue #2712). For v4.0.3 we'll do 8196 |
0987526 to
494e6bd
Compare
mayankchetan
approved these changes
Apr 1, 2025
Contributor
mayankchetan
left a comment
There was a problem hiding this comment.
Looks good to me, Thanks Andy! Let me know if you need help with the error file implementation for v6.0 :P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to merge (probably)
Feature or improvement description
The error messages have been far too short for complex messages or messages from FAST.Farm. Increasing it to
2^16 characters (maybe a bit of an overkill)2^13 characters (8192).This will result in more memory required for error messages.
In theory this should be enough (cue the "no-one will ever need more than 640k of memory..." quotes from the grey beards)...
Related issue, if one exists
#2701
Impacted areas of the software
The few users that read error messages will see more of the error messages
Additional supporting information
Another option is to increase the
ErrMsgLenby a more sane amount and change how we write errors to screen.Long term we will want to go with @bjonkman's solution - for 5.0.
Test results, if applicable
Output log text from test results may change slightly, but we don't check this data (timestamp always changes during testing).