Closed
Conversation
There is a bug in 2024 and 2025 IFX compiler that creates a conflict with `-lm` and `-ldl` if `check uninit` is enabled.
Add "nouninit" to debug flags for IntelLLVM
The `close(Un)` is not atomic, so it may not have released the file before declaring the unit available. This can cause issues with opening a whole bunch of files simulataneously. There are other places that need this fix as well.
Increase length of error messages
generate BD files if fst_vt dictionary BD keys are not empty
Co-authored-by: Derek Slaughter <deslaughter@gmail.com>
Changed fileopenNWTCio_critical to fileopen_critical so all file open is the same OMP critical
Also remove from Read84AryWDefault. Somehow this was triggering a segfault with IFX. No idea how.
Segmentation faults can occur if the OMP PARALLEL DO has enough private memory per thread that it exceeds the default OMP_STACKSIZE="4 M". If this happens, `export OMP_STACKSIZE="32 M"` or suitably large value. Calculating the values for this don't exactly work out as I would expect, but are in the ballpark (see code note)
The routine isn't actually used... yet. But for completeness adding the critical around the close so it isn't an issue later when I actually use the routine
…ory leak with the IFX compiler.
Disable use of heap arrays for the Intel fortran compilers
Fix FAST.Farm issues with OMP (segfaults mostly)
andrew-platt
added
Type: Documentation
FAST.Farm
Module: NWTC Lib
Compiler: Intel
Type: IO Readers/Writers
jjonkman
approved these changes
Apr 8, 2025
Collaborator
jjonkman
left a comment
jjonkman
left a comment
There was a problem hiding this comment.
Thanks for getting this release out!
bug in sim status days left
…tion build dependencies instead.
rthedin
approved these changes
Apr 8, 2025
rthedin
left a comment
rthedin
left a comment
There was a problem hiding this comment.
Looks good to me. Stress-tested it on a 114-turbine case for 10s. Everything is working as expected.
Fix VS build for FAST when using IFX Complier
pull bot
pushed a commit
to MRE-Code-Hub/openfast
that referenced
this pull request
Apr 9, 2025
Release 4.0.3
Collaborator
Author
|
This was merged into |
Collaborator
Author
|
THIS WAS MERGED!!!! Something on the backend at GH failed to show this as merged even though it was merged to main with commit 20632d7 on April 9, 2025. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Pull request to merge
rc-4.0.3intomainand create a tagged release for v4.0.3See the milestone and project pages for additional information
Test results, if applicable
See GitHub Actions
Release checklist:
AeroDisk_Driver_x64.exeAeroDyn_Driver_x64.exeAeroDyn_Driver_x64_OpenMP.exeAeroDyn_Inflow_c_binding_x64.dllAeroDyn_Inflow_c_binding_x64_OpenMP.dllBeamDyn_Driver_x64.exeDISCON.dll (x64)DISCON_ITIBarge.dll (x64)DISCON_OC3Hywind.dll (x64)DISCON_SC.dll (x64)FAST.Farm_x64.exeFAST.Farm_x64_OMP.exeFAST_SFunc.mexw64HydroDynDriver_x64.exeHydroDyn_C_Binding_x64.dllIinflowWind_c_binding_x64.dllInflowWind_Driver_x64.exeInflowWind_Driver_x64_OpenMP.exeMoorDyn_Driver_x64.exeMoorDyn_c_binding_x64.dllOpenFAST-Simulink_x64.dllopenfast_x64.exeSeaStateDriver_x64.exeSimpleElastoDyn_x64.exeSubDyn_x64.exeTurbsim_x64.exeUnsteadyAero_x64.exeChangelog
Overview
This release includes several bug fixes and improvements for FAST.Farm, including segmentation faults with large farms, file I/O collision fixes, increased error message length, and compile issues.
General
CMake Build System
#2709 Add "nouninit" to debug flags for IntelLLVM (@andrew-platt)
#2732 Disable use of heap arrays for the Intel fortran compilers (@deslaughter)
openfast_io
#2727 generate BD files if fst_vt dictionary BD keys are not empty (@mayankchetan)
Visual Studio build
#2742 Fix VS build for FAST when using IFX Complier (@deslaughter)
Solvers
FAST.Farm
#2711 Fix FAST.Farm issues with OMP (segfaults mostly) (@andrew-platt)
Module changes
NWTC library
#2710 Increase length of error messages (@andrew-platt)
#2741 bug in simulation status number of days left (@andrew-platt)
Input file changes
No input file changes are required from 4.0.2.