-
Notifications
You must be signed in to change notification settings - Fork 35
bumping python versions to 3.11-13 #1373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1373 +/- ##
==========================================
- Coverage 95.11% 93.20% -1.92%
==========================================
Files 165 165
Lines 12389 12389
==========================================
- Hits 11784 11547 -237
- Misses 605 842 +237
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
See OpenFreeEnergy/gufe#576 and relevant upstream openff-toolkit-feedstock issue. |
|
currently blocked by conda-forge/citeproc-py-feedstock#14 |
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to update the docs environment file.
|
|
||
| - Python 3.10, 3.11, 3.12 - **we do not yet support Python 3.13** | ||
| - OpenMM 8.0, 8.1.1, 8.1.2, 8.2.0 - **we do not yet support OpenMM v8.3.0** | ||
| - `OpenEye Toolkits` is not yet compatible with Python 3.13, so **openfe** cannot use openeye functionality with Python 3.13. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is clear! I was going to add a bit about if you want to use the openeye toolkit with openfe, you need to install python 3.12 or something but I think this makes it pretty clear and saves us from having to make some recommendation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind this being here, but I honestly wouldn't bother. OpenEye functionality is limited to elf10, and we don't advertise it in our docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will probably need to make the same changes in our other repos as well.
Co-authored-by: Mike Henry <11765982+mikemhenry@users.noreply.github.com>
|
No API break detected ✅ |
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned elsewhere, the fact that we can't do python 3.13 w/ oechem isn't a big deal since it doesn't affect anything else but the one partial charge assignment option. Being too loud about it might end up confusing our users (who expect to not have openeye as a dependency).
resolves #1028
blocked by #1374 and OpenFreeEnergy/gufe#576 OpenFreeEnergy/gufe#577
Checklist
newsentryDevelopers certificate of origin