Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Jun 13, 2025

resolves #1028
blocked by #1374 and OpenFreeEnergy/gufe#576 OpenFreeEnergy/gufe#577

Checklist

  • Added a news entry

Developers certificate of origin

@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.20%. Comparing base (255ac7f) to head (648473b).
⚠️ Report is 125 commits behind head on main.

Files with missing lines Patch % Lines
...s/protocols/openmm_rfe/test_hybrid_top_protocol.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
- Coverage   95.11%   93.20%   -1.92%     
==========================================
  Files         165      165              
  Lines       12389    12389              
==========================================
- Hits        11784    11547     -237     
- Misses        605      842     +237     
Flag Coverage Δ
fast-tests 93.20% <92.59%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IAlibay
Copy link
Member

IAlibay commented Jun 18, 2025

See OpenFreeEnergy/gufe#576 and relevant upstream openff-toolkit-feedstock issue.

@atravitz
Copy link
Contributor Author

currently blocked by conda-forge/citeproc-py-feedstock#14

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update the docs environment file.

@atravitz atravitz added this to the v1.6.0 milestone Jul 15, 2025
@atravitz atravitz removed the blocked label Jul 15, 2025
@atravitz atravitz requested review from IAlibay and mikemhenry July 15, 2025 20:39

- Python 3.10, 3.11, 3.12 - **we do not yet support Python 3.13**
- OpenMM 8.0, 8.1.1, 8.1.2, 8.2.0 - **we do not yet support OpenMM v8.3.0**
- `OpenEye Toolkits` is not yet compatible with Python 3.13, so **openfe** cannot use openeye functionality with Python 3.13.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clear! I was going to add a bit about if you want to use the openeye toolkit with openfe, you need to install python 3.12 or something but I think this makes it pretty clear and saves us from having to make some recommendation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind this being here, but I honestly wouldn't bother. OpenEye functionality is limited to elf10, and we don't advertise it in our docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will probably need to make the same changes in our other repos as well.

Co-authored-by: Mike Henry <11765982+mikemhenry@users.noreply.github.com>
@github-actions
Copy link

No API break detected ✅

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned elsewhere, the fact that we can't do python 3.13 w/ oechem isn't a big deal since it doesn't affect anything else but the one partial charge assignment option. Being too loud about it might end up confusing our users (who expect to not have openeye as a dependency).

@IAlibay IAlibay merged commit e91b964 into main Jul 16, 2025
12 of 13 checks passed
@IAlibay IAlibay deleted the add_python_3.13_to_ci branch July 16, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add python 3.13 to ci matrix

4 participants