Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Oct 10, 2025

This is a first pass at moving us to a manual trigger for precommit so that we can add more opinionated hooks (like ruff) down the line.

  • add more checks
  • make precommit manual

Checklist

  • Added a news entry

Developers certificate of origin

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.88%. Comparing base (1152edd) to head (5bea3fc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1567      +/-   ##
==========================================
- Coverage   95.33%   92.88%   -2.45%     
==========================================
  Files         183      183              
  Lines       15763    15763              
==========================================
- Hits        15028    14642     -386     
- Misses        735     1121     +386     
Flag Coverage Δ
fast-tests 92.88% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz marked this pull request as ready for review October 27, 2025 17:22
@mikemhenry
Copy link
Contributor

This PR actually doesn't make it manual, but enables a YAML syntax check + disables that check for a file that is a mix of yaml and jinja

@mikemhenry mikemhenry changed the title add precommit hooks, make running manual add yaml syntax check precommit hooks Oct 27, 2025
@mikemhenry
Copy link
Contributor

I just changed the tile to make it clear at a glance in the log

@mikemhenry mikemhenry enabled auto-merge (squash) October 27, 2025 17:49
@atravitz
Copy link
Contributor Author

This PR actually doesn't make it manual, but enables a YAML syntax check + disables that check for a file that is a mix of yaml and jinja

ah, thank you! the original changes in this ended up getting merged with the first ruff PR. Thanks for keeping the commit log clean

@atravitz atravitz disabled auto-merge October 28, 2025 15:08
@atravitz atravitz merged commit 7b585fe into main Oct 28, 2025
9 of 12 checks passed
@atravitz atravitz deleted the ci/add-precommit-hooks branch October 28, 2025 15:08
@github-actions
Copy link

No API break detected ✅

@atravitz atravitz mentioned this pull request Dec 4, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants