-
Notifications
You must be signed in to change notification settings - Fork 35
add yaml syntax check precommit hooks #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1567 +/- ##
==========================================
- Coverage 95.33% 92.88% -2.45%
==========================================
Files 183 183
Lines 15763 15763
==========================================
- Hits 15028 14642 -386
- Misses 735 1121 +386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR actually doesn't make it manual, but enables a YAML syntax check + disables that check for a file that is a mix of yaml and jinja |
|
I just changed the tile to make it clear at a glance in the log |
ah, thank you! the original changes in this ended up getting merged with the first ruff PR. Thanks for keeping the commit log clean |
|
No API break detected ✅ |
This is a first pass at moving us to a manual trigger for precommit so that we can add more opinionated hooks (like ruff) down the line.
Checklist
newsentryDevelopers certificate of origin