Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Oct 27, 2025

#1567 (comment)

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz requested a review from mikemhenry October 27, 2025 17:19
@github-actions
Copy link

No API break detected ✅

Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need an upper bound on our python version support. IMHO it just makes it hard to install in a python 3.14 environment and I am not sure what the upsides are. I saw #1567 (comment) and it actually looks like we are blocked by the openff-* ecosystem https://github.com/conda-forge/openff-toolkit-feedstock/blob/main/recipe/meta.yaml

I know we didn't have an upper bound on our last release, but if we did, that means if tomorrow openff-* supported python 3.14, a user wouldn't be able to install openfe in python 3.14

tl;dr I think our requirements should be what our code requires and not what functionally happens (sone dependency not supporting a python version) at some point in time.

P.S. Right now openmm 8.4 doesn't have python 3.14 builds (there is an RC) BUT if tomorrow they did, we still couldn't install our software in a python 3.14 environment b/c of openf-*

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.88%. Comparing base (fe2d11c) to head (fdea483).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1629      +/-   ##
==========================================
- Coverage   95.33%   92.88%   -2.45%     
==========================================
  Files         183      183              
  Lines       15763    15763              
==========================================
- Hits        15028    14642     -386     
- Misses        735     1121     +386     
Flag Coverage Δ
fast-tests 92.88% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz
Copy link
Contributor Author

@mikemhenry - I think your opinion here follows our general best-practice, so I'm closing this PR 👍

@atravitz atravitz closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants