-
Notifications
You must be signed in to change notification settings - Fork 35
Ci/add ruff format to openfe protocols #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
==========================================
- Coverage 95.33% 92.88% -2.45%
==========================================
Files 183 183
Lines 15765 15765
==========================================
- Hits 15030 14644 -386
- Misses 735 1121 +386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
atravitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I've addressed all your comments @IAlibay . Thanks for the feedback, and I'll carry these conventions through to the rest of the code.
|
trailing comma is a black convention thing! https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#trailing-commas @IAlibay |
| # Enable Pyflakes (`F`) and a subset of the pycodestyle (`E`) codes by default. | ||
| lint.select = [ | ||
| # "F", # Pyflakes | ||
| # "I", # isort |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we waiting to do isort on a seperate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep! first comes formatting, then linting will be later.
|
No API break detected ✅ |
it's a big one!
for whoever is reviewing: i recommend going through by commit, since I split it into more digestible chunks that are "skimmable" vs "alyssa made some choices here"
related to #1478
Checklist
newsentryDevelopers certificate of origin