Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Oct 22, 2025

follow-up to #1604

there will be one more PR that formats all the tests, then we're done!

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz requested a review from IAlibay October 22, 2025 23:16
@atravitz atravitz requested a review from mikemhenry October 22, 2025 23:34
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 93.30544% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.88%. Comparing base (25933de) to head (dce18fc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
openfecli/commands/gather.py 79.66% 12 Missing ⚠️
openfe/setup/atom_mapping/perses_mapper.py 66.66% 1 Missing ⚠️
openfe/setup/atom_mapping/perses_scorers.py 90.00% 1 Missing ⚠️
openfe/utils/visualization_3D.py 87.50% 1 Missing ⚠️
openfecli/commands/atommapping.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1610      +/-   ##
==========================================
- Coverage   95.33%   92.88%   -2.45%     
==========================================
  Files         183      183              
  Lines       15765    15763       -2     
==========================================
- Hits        15030    14642     -388     
- Misses        735     1121     +386     
Flag Coverage Δ
fast-tests 92.88% <93.30%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one thing, otherwise lgtm.

atravitz and others added 5 commits October 24, 2025 11:31
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
* bump example notebooks branch

* add ipykernel to env

* roll back to fixing septop branch

* i dont think we want ipykernel

* bump to tmp_fix_docs branch

* point to branch revert-237-v1.7_cookbooks

* point to latest example notebooks release
…g page (#1618)

* remove colab button from example notebooks in docs

* point to example notebooks 2025.10.2

* replace 'try' with CLI
@github-actions
Copy link

No API break detected ✅

@atravitz atravitz merged commit 2311a2f into main Oct 24, 2025
12 of 13 checks passed
@atravitz atravitz deleted the ci/add-ruff-format-part2 branch October 24, 2025 21:09
@atravitz atravitz mentioned this pull request Dec 4, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants