Pile-up #706
Open
Pile-up #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gertvanhoey
force-pushed
the
pileup
branch
2 times, most recently
from
1ef304f to
4a869c7
Compare
Contributor
Author
|
Hello @kochebina, @dsarrut, @nkrah, I spent some time lately finishing the pile-up implementation. It is intended to work in the same way as the pile-up functionality in GATE 9. Since it was my first time writing an Actor, it would be good if you could check in the code that it is done correctly. I still need to add documentation. |
Closed
Contributor
|
Thanks a lot Gert! I switch to PR #854 to allow modifications |
… deposited energy
…es of singles after pile-up
…irst digi, sum of energy of all digis, energy-weighted position of all digis, other attributes from highest-energy digi
Contributor
Author
|
@dsarrut @kochebina @tbaudier The pile-up actor has been reworked to use GateDigiCollection internally, time-sorting has been added prior to pile-up, and the documentation is updated. It is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @kochebina, @dsarrut, @nkrah, I started off with creating an actor that for now does nothing more than pass singles unchanged, and check that it works in a test. Next step will be to figure out how to "remember" singles and combine them as needed, so that this actor works the same as the pile-up functionality in GATE 9. If you any feedback on this already (e.g. concerning naming), please let me know.