Gertvanhoey pileup #854
Closed
Gertvanhoey pileup #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deposited energy
…es of singles after pile-up
…nitialization logic.
… and `GateTLEDoseActor` bindings for consistency.
…r` and refactor related members for clarity
…Actor` initialization
…r` initialization
…bsSolid` classes for improved development experience
… errors and refine tick generation logic in test visualization for consistent spacing.
…ility to output folder naming, and move functions to spect_helpers
…tions to `spect_helpers`, improving modularity and functionality
…eprecating ITK-based energy window extraction, and introducing `spect_freeflight_helpers` for advanced SPECT freeflight calculations.
…sing, and add context for multithreaded initialization
…in FreeFlightActor and clarify related comments
…ty, and update comments
…nused comment, and check fSquaredImageIsEnabled before flushing
…g, and improve readability
add documentation for multiple run
trying to put a link to test 096
link to test096 done
updates: - [github.com/psf/black-pre-commit-mirror: 25.9.0 → 25.11.0](psf/black-pre-commit-mirror@25.9.0...25.11.0) - [github.com/pre-commit/mirrors-clang-format: v21.1.2 → v21.1.5](pre-commit/mirrors-clang-format@v21.1.2...v21.1.5)
…const qualifiers, and improve comments for readability
updates: - [github.com/pre-commit/mirrors-clang-format: v21.1.5 → v21.1.6](pre-commit/mirrors-clang-format@v21.1.5...v21.1.6)
Open
Contributor
|
bad merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pileup from Gert's #706. This is really excellent, thanks a lot !
Questions for you Gert :
Can you try to replace the "PileupGroup" management by a GateDigiCollection ?
it could be something like std::map<uint64_t, GateDigiCollection*> volume_groups;
The list of managed attributes for the GateDigiCollection is the same every time, so it can probably be only build once, the first time the volume is seen. The next events, the same GateDigiCollection could be used, we only need to reset the content. This modification would allow to be more robust if additional attribute types are created later. Moreover, it will simplify the code.
This pileup policy is one possibility but there are others (nonparalyzable or paralyzable etc), no ? Can you explicitly indicate which policy it is please ? Other policies will be added in the future.
It is almost multi-thread ready. I will make it MT in a second stage.
thanks again !