Refactoring 01 (MVP): init refactor #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2020
chreman
added a commit
to chreman/Headstart
that referenced
this pull request
Oct 13, 2021
…toring-01-mvp-init Refactoring 01 (MVP): init refactor Former-commit-id: 359bb24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces another part of the MVP refactoring: the refactored and fixed
init_start_visualizationfunction in the mediator.Changes summary:
init_start_visualizationis changed, so the canvas setup (with the heading measurement) happens AFTER the whole heading is rendered. I had to splitprepareDatafunction (io.js) into two. The whole call sequence is simplified, so there's no repeated code.initScalesfunction call to the constructor.