Refactoring 01 (MVP): old code removal #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and moved them back to the right
all occurences of modern_frontend_enabled removed prepared for another round
…over Refactoring 01 (MVP): popover fix
chreman
added a commit
to chreman/Headstart
that referenced
this pull request
Oct 13, 2021
…toring-01-mvp-legacy-removal Refactoring 01 (MVP): old code removal Former-commit-id: ef0087c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this PR before #481 and #483 and also #484
The old code that creates and manages the MVP parts (heading, context line, author image...) is removed for good. From now, the whole MVP is created by React + Redux only. There's no difference between enabled and disabled frontend flag.
draw_titlefunction todraw_modals, because that's its only purpose nowI tested this on project website, covis and local examples.