Skip to content

Revert @jpfeuffer [10 - 11] Jun, 2022 +0200 recent commits #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jpfeuffer merged 18 commits into from
Jun 13, 2022
Merged

Revert @jpfeuffer [10 - 11] Jun, 2022 +0200 recent commits #97

jpfeuffer merged 18 commits into from
Jun 13, 2022

Conversation

@tapaswenipathak
Copy link
Contributor

@tapaswenipathak tapaswenipathak commented Jun 13, 2022

  1. [commit history][small changes per commit] None of the commits work or are added in a way that can be fixed, to be precise 10 commits. (~update to installation instructions)
  2. [undefined, unspecified] Syntax added is incorrect but just works or might work.
  3. [multiple tabs] UI/UX changes were unreviewed.
  4. [myst_heading_anchors bug added] breaks existing links. ref: f112e79.
  5. [w/o squash and merge][unreviewed][untested] pr merged on staging; primary branch for everyone working. Major fix of installation instructions #90.
  6. Contributing guidelines not followed.

cc @jpfeuffer

cc @axelwalter @enetz @KyowonJeong @poshul @OpenMS/doc-team.

Screenshot 2022-06-13 at 8 31 50 AM

Screenshot 2022-06-13 at 8 34 03 AM

Describe the change

PR checklist

@tapaswenipathak
Address review comments by @greengypsy
2af8b38 
Ref: OpenMS#65.
@tapaswenipathak
Merge remote-tracking branch 'upstream/staging' into staging
5ce7c7b
@tapaswenipathak
add: exact syntax for adding admonition
f17e6f8
@tapaswenipathak
add: soon to be deprecated important admonition for toppas
509a43b
@tapaswenipathak
Merge remote-tracking branch 'upstream/staging' into staging
84d20f3
@tapaswenipathak
add: remaining toppview-introduction content
e167563 
Closes OpenMS#76.
@tapaswenipathak
prettier: ui enhancements
025faea 
Fixes OpenMS#66.
Fixes OpenMS#71.
Closes OpenMS#79.
Fixes OpenMS#81.
@tapaswenipathak
fixes: merge conflicts
a940f0a
@tapaswenipathak
Merge remote-tracking branch 'upstream/staging' into staging
78f55ab
@tapaswenipathak
Merge branch 'staging' of github.com:OpenMS/OpenMS-docs into staging
3e43aa3
@tapaswenipathak
Revert "Try adding autosection"
2c0f172 
This reverts commit e1f5b66.
@tapaswenipathak
Revert "try different link syntax"
fea3534 
This reverts commit 940fbdf.
@tapaswenipathak
Revert "Update conda instructions for macOS"
75cd3c0 
This reverts commit 4e7cf57.
@tapaswenipathak
Revert "[FIX] allow crosslinking in markdown"
a1a7f69 
This reverts commit 0241aa2.
@tapaswenipathak
Revert "whitespace"
8a8cb20 
This reverts commit 83540a0.
@tapaswenipathak
Revert "Fixes to tabbing"
dbe2345 
This reverts commit b46d112.
@tapaswenipathak
Revert "Fix"
46cd6cc 
This reverts commit eaf3a63.
@tapaswenipathak
Revert "Major fix of installation instructions"
6113117 
This reverts commit ab7106e.
@jpfeuffer jpfeuffer merged commit e9b656c into OpenMS:staging Jun 13, 2022
@tapaswenipathak tapaswenipathak deleted the revert-@jpfeuffer-10-11-0200-recent-commits branch June 16, 2022 07:04
@tapaswenipathak tapaswenipathak mentioned this pull request Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tapaswenipathak @jpfeuffer