Skip to content

Conversation

@adeas31
Copy link
Member

@adeas31 adeas31 commented Nov 27, 2020

Workaround for #130

# set omc executable path and args
self._set_omc_command([
"--interactive=zmq",
"--locale=C",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work with some older OMC versions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you talking about like 1.12 or later. Anyway people using such old OMC can use older pip install version of OMPython.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then that information concerning the minimum OMC version should probably be put somewhere (Readme, setup.py, warning at import time?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I load 1.9 versions of OMC that are older than this, and they work just fine... For zmq you could put it, but I guess not CORBA

@adeas31
Copy link
Member Author

adeas31 commented Dec 9, 2020

Since the translations are removed from OMC so this issue will not be seen in the future versions anyway. One idea is to close this PR. What do you think @sjoelund? Shall I close or merge this?

@adeas31 adeas31 merged commit 1b68a80 into OpenModelica:master Feb 18, 2021
@adeas31 adeas31 deleted the locale branch February 18, 2021 14:06
@adeas31 adeas31 mentioned this pull request Feb 18, 2021
@casella
Copy link

casella commented Feb 18, 2021

RIP multilingual support. I always switched to English anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants