Skip to content

Avoid using translations #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adeas31 merged 2 commits into from
Feb 18, 2021
Merged

Avoid using translations #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bbae4c
Avoid using translations
adeas31 Nov 27, 2020
4503db5
Don't fix locale for CORBA
adeas31 Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@
.idea/
.vs/
.DS_Store
.vscode/
1 change: 1 addition & 0 deletions OMPython/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,7 @@ def __init__(self, readonly=False, timeout = 10.00, docker = None, dockerContain
# set omc executable path and args
self._set_omc_command([
"--interactive=zmq",
"--locale=C",
Copy link
Member

@sjoelund sjoelund Nov 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work with some older OMC versions

Copy link
Member Author

@adeas31 adeas31 Nov 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you talking about like 1.12 or later. Anyway people using such old OMC can use older pip install version of OMPython.

Copy link

@bilderbuchi bilderbuchi Nov 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then that information concerning the minimum OMC version should probably be put somewhere (Readme, setup.py, warning at import time?)

Copy link
Member

@sjoelund sjoelund Nov 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I load 1.9 versions of OMC that are older than this, and they work just fine... For zmq you could put it, but I guess not CORBA

"-z={0}".format(self._random_string)
])
# start up omc executable, which is waiting for the ZMQ connection
Expand Down