Skip to content

Feature/64 colour coding of results table#69

Merged
stellaprins merged 17 commits intodevelopmentfrom
feature/64-colour-coding-of-results-table
Oct 28, 2024
Merged

Feature/64 colour coding of results table#69
stellaprins merged 17 commits intodevelopmentfrom
feature/64-colour-coding-of-results-table

Conversation

@stellaprins
Copy link
Collaborator

@stellaprins stellaprins commented Oct 24, 2024

fixed using emojis (#64 )

  • ✅pass
  • ❎xfail
  • ❌FAIL
  • ⚠warning

@stellaprins stellaprins self-assigned this Oct 24, 2024
@stellaprins stellaprins marked this pull request as ready for review October 24, 2024 19:22
@stellaprins stellaprins requested a review from robertvi October 24, 2024 19:22
@pgleeson
Copy link
Member

Looks good!

Having a fresh look at https://github.com/OpenSourceBrain/SBMLShowcase/blob/feature/64-colour-coding-of-results-table/SBML/tests/results_compatibility_biosimulators.md though, it is a bit difficult to quickly distinguish between the green cross and tick. Maybe use a yellow/orange background cross/symbol for the xfail? (or try something like <span style="color:#FFFF00;">symbol</span>)

Also, if the message in "Error (R)" column refers to the outcome of the test in "pass / FAIL (R)", would it not be better to put this as an expandable arrow under the XFAIL/FAIL message in the "Error (R)" column, not in separate columns?

Also (and I'm being picky now...) add a space between the emoji and consistent capitalisation, so ✅ PASS, etc.

@stellaprins
Copy link
Collaborator Author

stellaprins commented Oct 28, 2024

@pgleeson all great points! Have a look at the table here.

I've added your point below to issue #68

Also, if the message in "Error (R)" column refers to the outcome of the test in "pass / FAIL (R)", would it not be better to put this as an expandable arrow under the XFAIL/FAIL message in the "Error (R)" column, not in separate columns?

@stellaprins stellaprins merged commit 1acd2db into development Oct 28, 2024
@stellaprins stellaprins deleted the feature/64-colour-coding-of-results-table branch October 28, 2024 10:10
@pgleeson
Copy link
Member

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants