Feature/64 colour coding of results table#69
Conversation
…ompatible-engines
…feature/64-colour-coding-of-results-table
…ollapsible content xfail in compat col
|
Looks good! Having a fresh look at https://github.com/OpenSourceBrain/SBMLShowcase/blob/feature/64-colour-coding-of-results-table/SBML/tests/results_compatibility_biosimulators.md though, it is a bit difficult to quickly distinguish between the green cross and tick. Maybe use a yellow/orange background cross/symbol for the xfail? (or try something like Also, if the message in "Error (R)" column refers to the outcome of the test in "pass / FAIL (R)", would it not be better to put this as an expandable arrow under the XFAIL/FAIL message in the "Error (R)" column, not in separate columns? Also (and I'm being picky now...) add a space between the emoji and consistent capitalisation, so ✅ PASS, etc. |
…add warning emoji for xfails
|
@pgleeson all great points! Have a look at the table here. I've added your point below to issue #68
|
|
Looks good, thanks! |
fixed using emojis (#64 )