Merged
Conversation
…SED-ML files without them being overwritten (use_original_files)
…with modified x limit
Collaborator
|
If the spaces in the filename are causing problems due to being run as part of a shell script in our code, then it might be worth also trying to wrap the filename parameters to the shell script in double quotes to make them robust to spaces. But if the problem is inside a function we didn't write them perhaps bug report to the author's GH could be possible? |
robertvi
reviewed
Dec 2, 2024
… Put unix command between single quotes.
…_xmlns_fbc_attribute
…enSourceBrain/SBMLShowcase into feat-87-2-test-more-biomodels
Collaborator
Author
|
Thanks, I've added the quotes, a bug fix (temp SED-ML file handling in add_xmlns_sbml_attribute and add… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Removes spaces from omex filenames before mounting the files to the docker container
Addresses issue #87
Merge after #84