Improve encoding performance#2
Open
bagarey wants to merge 2 commits into
Open
Conversation
https://stackoverflow.com/questions/46095870/whats-the-best-way-to-build-long-strings-in-elixir This has been modified to append short binaries to longer ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with a big XML file (13MB output, 10,000s of elements) we found it took 40s to encode it only. We found a way to optimize binary concatenation:
https://stackoverflow.com/questions/46095870/whats-the-best-way-to-build-long-strings-in-elixir
With the changes below the XML file encodes in 1.5s on our machines. Would you consider merging our changes back into your project?
Thank you