Skip to content

Improve encoding performance #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bagarey wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve encoding performance #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10611e9
Improve encoding performance
bagarey Sep 10, 2019
2e8af15
Align with the fix
bagarey Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/exoml/encoder.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,37 +5,37 @@ defmodule Exoml.Encoder do
end

defp encode(bin, acc) when is_binary(bin) do
bin <> acc
acc <> bin
end

defp encode([node | tl], acc) do
encode(node, encode(tl, acc))
encode(tl, encode(node, acc))
end

defp encode([], acc), do: acc

defp encode({:prolog, attrs, nil}, acc) do
"<?xml " <> encode_attrs(attrs) <> " ?>" <> acc
acc <> "<?xml " <> encode_attrs(attrs) <> " ?>"
end

defp encode({:doctype, attrs, nil}, acc) do
"<!DOCTYPE" <> encode_attrs(attrs) <> " !>" <> acc
acc <> "<!DOCTYPE" <> encode_attrs(attrs) <> " !>"
end

defp encode({tag, [], nil}, acc) do
"<#{tag}/>" <> acc
acc <> "<#{tag}/>"
end

defp encode({tag, attrs, nil}, acc) do
"<#{tag} #{encode_attrs(attrs)} />" <> acc
acc <> "<#{tag} #{encode_attrs(attrs)} />"
end

defp encode({tag, [], children}, acc) do
"<#{tag}>" <> encode(children, "") <> "</#{tag}>" <> acc
acc <> "<#{tag}>" <> encode(children, "") <> "</#{tag}>"
end

defp encode({tag, attrs, children}, acc) do
"<" <> tag <> " " <> encode_attrs(attrs) <> ">" <> encode(children, "") <> "</#{tag}>" <> acc
acc <> "<" <> tag <> " " <> encode_attrs(attrs) <> ">" <> encode(children, "") <> "</#{tag}>"
end

defp encode_attrs(attrs) do
Expand Down