Allow using observable IDs in observableFormula and noiseFormula
#562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following up on #543 and the discussion during the last PEtab editor meeting: There was general consent to allow using observableIDs in the `noiseFormula` column in the observables table. What was not discussed explicitly: * Should all observable IDs be allowed, or only the current one? * If so, should it be allowed to use observable IDs inside `observableFormula`? CC @PEtab-dev/petab-editors Closes ##543
dweindl
requested review from
FFroehlich,
JanHasenauer,
SeverinBang,
fbergmann and
matthiaskoenig
fbergmann
approved these changes
Jun 27, 2023
Contributor
fbergmann
left a comment
fbergmann
left a comment
There was a problem hiding this comment.
Those changes look good to me. Thanks!
Contributor
|
As to
I'm fine with allowing all.
I don't see a problem with that, as long as this introduces no circularity, which you addressed in the PR. |
dilpath
approved these changes
Jun 27, 2023
Member
dilpath
left a comment
dilpath
left a comment
There was a problem hiding this comment.
Looks good to me.
Could change the example to be
noiseParameter1_observable_pErk + noiseParameter2_observable_pErk*observable_pErk
instead of
noiseParameter1_observable_pErk + noiseParameter2_observable_pErk*pErk
Should all observable IDs be allowed, or only the current one?
Fine for me to allow all observable IDs.
If so, should it be allowed to use observable IDs inside
observableFormula?
Fine for me to allow all observable IDs inside observableFormula.
FFroehlich
approved these changes
Jun 26, 2024
dweindl
commented
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #543 and the discussion during the last PEtab editor meeting: There was general consent to allow using observableIDs in the
noiseFormulacolumn in the observables table.What was not discussed explicitly:
observableFormula?CC @PEtab-dev/petab-editors
Closes #543